Windows: Update ANGLE surface size when window is resized #94428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`WM_WINDOWPOSCHANGED` may be received before `CreateWindowExW` has even returned, when the window's rendering context or OpenGL context hasn't been created yet.
ANGLE needs to be told to resize the DXGI swap chain using `eglWaitNative`. Otherwise the resize will only happen in `eglSwapBuffers`, which causes some janky stretching during window resize.
bruvzg
approved these changes
Jul 25, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ANGLE needs to be told to resize the DXGI swap chain using
eglWaitNative. Otherwise the resize will only happen ineglSwapBuffers, which causes some janky stretching during window resize.See: https://github.com/google/angle/blob/43ecf2bd98fc9dd135c82d6b153e18bf1fbcaf37/src/libANGLE/renderer/d3d/DisplayD3D.cpp#L401
This only fixes part of the issue because DisplayServerWindows does not currently force update and redraw during resize, which I aim to address separately.
Demo (GIF)
Before:
After: (the slowness is probably from being a debug build)
Fixes #94951